lk2nd: display: panel: Introduce custom oem_panel implementation #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderfulShrineMaidenOfParadise
force-pushed
the
lk1st-panel
branch
from
6cb1453
to
63cfbba
Compare
lk2nd/display/panel/generated/lk_panel_ili9806e_boyi_byt45mp41t1m_4p5cpt.h
Show resolved
Hide resolved
wonderfulShrineMaidenOfParadise
force-pushed
the
lk1st-panel
branch
from
63cfbba
to
b25ae53
Compare
wonderfulShrineMaidenOfParadise
force-pushed
the
lk1st-panel
branch
3 times, most recently
from
bc80423
to
cb963fe
Compare
TravMurav
reviewed
Jun 19, 2024
| @@ -28,7 +28,9 @@ static int lk2nd_simplefb_dt_update(void *dtb, const char *cmdline, | |||
| int ret, resmem_offset, chosen_offset, offset; | |||
| uint32_t mem_ph, fb_size; | |||
| char tmp[32], args[16]; | |||
| #if WITH_LK2ND_DISPLAY_CONT_SPLASH | |||
There was a problem hiding this comment.
commit subject -> "...: Only support arguments if const-splash is used" maybe
lk2nd/display/rules.mk
Outdated
Comment on lines
9
to
14
| else ifneq ($(LK2ND_DISPLAY),) | ||
| include $(LOCAL_DIR)/panel/rules.mk | ||
| else | ||
| $(error Display '$(LK2ND_DISPLAY)' is not supported yet) | ||
| endif |
There was a problem hiding this comment.
Suggested change
| else ifneq ($(LK2ND_DISPLAY),) | |
| include $(LOCAL_DIR)/panel/rules.mk | |
| else | |
| $(error Display '$(LK2ND_DISPLAY)' is not supported yet) | |
| endif | |
| else ifneq ($(LK2ND_DISPLAY),) | |
| include $(LOCAL_DIR)/panel/rules.mk | |
| else | |
| $(error Please specify the display with LK2ND_DISPLAY option) | |
| endif |
since it always be empty value for the last else now.
TravMurav
reviewed
Jun 19, 2024
| panel->paneltiminginfo = &hx8394d_720p_video_timing_info; | ||
| panel->panelresetseq = &hx8394d_720p_video_reset_seq; | ||
| panel->backlightinfo = &hx8394d_720p_video_backlight; | ||
| pinfo->mipi.panel_on_cmds = hx8394d_720p_video_on_command; |
There was a problem hiding this comment.
Suggested change
| pinfo->mipi.panel_on_cmds = hx8394d_720p_video_on_command; | |
| pinfo->mipi.panel_on_cmds = hx8394d_720p_video_on_command; | |
| pinfo->mipi.panel_off_cmds = hx8394d_720p_video_off_command; |
Can you check if this doesn't break the display? Not sure why lmdpdg doesn't generate this...
There was a problem hiding this comment.
Suggested-by: Nikita Travkin <[email protected]>
wonderfulShrineMaidenOfParadise
force-pushed
the
lk1st-panel
branch
2 times, most recently
from
9b1b629
to
147eda5
Compare
The oem_panel implementation from Qualcomm is terrible because it always includes *all* panel implementations in the binary and requires writing lots of code to add support for a new panel. To make this easier for lk1st, let's add a custom oem_panel implementation. The panel implementation is automatically selected using LK1ST_PANEL= on the make command line, which should be the panel ID in lower case, e.g. LK1ST_PANEL=adv7533_1080p_video.
```
lk2nd/display/panel/oem_panel.c:45:5: warning: no previous prototype for 'oem_panel_select' [-Wmissing-prototypes]
45 | int oem_panel_select(const char *panel_name, struct panel_struct *panel,
| ^~~~~~~~~~~~~~~~
```
wonderfulShrineMaidenOfParadise
changed the title
Otherwise the screen does not turn on.
wonderfulShrineMaidenOfParadise
force-pushed
the
lk1st-panel
branch
from
147eda5
to
28387ff
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.